Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace just-repo-utils with workspace-tools #791

Merged
merged 2 commits into from Jul 24, 2021

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Jul 16, 2021

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Removes just-repo-utils in favour of workspace-tools.

Verification

  • Verified that test apps work
  • Tests pass

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts
@tido64 tido64 requested review from afoxman, Saadnajmi and JasonVMo Jul 16, 2021
const {getWatchFolders} = require('@uifabricshared/build-native');
const {defaultWatchFolders} = require('@rnx-kit/metro-config');
Comment on lines 8 to 8

This comment has been minimized.

@Saadnajmi

Saadnajmi Jul 16, 2021
Contributor

less references to "@ uifabricshared" makes me happy :D

@@ -26,7 +26,6 @@
"checkchange": "beachball check --changehint \"Run 'yarn change' to generate a change file\"",
"depcheck": "rnx-dep-check && lage depcheck",
"lint": "lage lint",
"postinstall": "node ./scripts/postinstall.js",

This comment has been minimized.

@Saadnajmi

Saadnajmi Jul 16, 2021
Contributor

Why is this removed?

This comment has been minimized.

@tido64

tido64 Jul 16, 2021
Author Member

The script is deleted 😄
image

This comment has been minimized.

@Saadnajmi

Saadnajmi Jul 16, 2021
Contributor

Ah, it's functionality moved upstream. Thanks!

@tido64 tido64 force-pushed the tido/remove-just-repo-utils branch from fdff827 to 6cb3c99 Jul 23, 2021
@JasonVMo JasonVMo merged commit 69c607c into master Jul 24, 2021
10 checks passed
10 checks passed
@azure-pipelines
PR Build #20210723.15 succeeded
Details
@azure-pipelines
PR (Android PR) Android PR succeeded
Details
@azure-pipelines
PR (Apple PR ios) Apple PR ios succeeded
Details
@azure-pipelines
PR (Apple PR macos) Apple PR macos succeeded
Details
@azure-pipelines
PR (Build, test, and bundle JavaScript) Build, test, and bundle JavaScript succeeded
Details
@azure-pipelines
PR (NuGet Publish Dry Run) NuGet Publish Dry Run succeeded
Details
@azure-pipelines
PR (Win32 PR) Win32 PR succeeded
Details
@azure-pipelines
PR (Windows PR) Windows PR succeeded
Details
@msftbot
auto-merge.config.enforce No dynamic merge policies are applicable.
@microsoft-cla
license/cla All CLA requirements met.
Details
@tido64 tido64 deleted the tido/remove-just-repo-utils branch Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants