Skip to content

/ transformers

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message to Wav2Vec2 & Hubert if labels > vocab_size #12270

Open
patrickvonplaten opened this issue Jun 20, 2021 · 1 comment
Open

Add error message to Wav2Vec2 & Hubert if labels > vocab_size #12270

patrickvonplaten opened this issue Jun 20, 2021 · 1 comment
Labels
Good First Issue

Comments

@patrickvonplaten
Copy link
Member

@patrickvonplaten patrickvonplaten commented Jun 20, 2021

🚀 Feature request

Add better error message to HubertForCTC, Wav2Vec2ForCTC if labels are bigger than vocab size.

Motivation

Following this issue: #12264 it is clear that an error message should be thrown if any of the any of the labels are > self.config.vocab_size or else silent errors can sneak into the training script.

So we should modify: Wav2Vec2ForCTC, TFWav2Vec2ForCTC, and HubertForCTC to add a nice error message in this case.

Your contribution

This is a first good issue and should be rather easy to accomplish. I'm happy to give more guidance if needed.
@vasudevgupta7
Copy link
Contributor

@vasudevgupta7 vasudevgupta7 commented Jun 20, 2021

I will create a PR to fix this.
@will-rice will-rice mentioned this issue Jun 21, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@patrickvonplaten @vasudevgupta7