Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly cache ember types from prepublish hook #3749

Merged
merged 3 commits into from Jul 1, 2021

Conversation

@kamilogorek
Copy link
Member

@kamilogorek kamilogorek commented Jun 25, 2021

We are performing npm pack and release artifacts uploads based on the previously created cache. These files, which are necessary for correct ember builds were not cached, thus never included in the package tarballs.

ref: #3516 (comment)

@kamilogorek kamilogorek requested review from HazAT, k-fish, getsentry/team-webplatform and iker-barriocanal and removed request for getsentry/team-webplatform Jun 25, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jun 25, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.39 KB (0%)
@sentry/browser - Webpack 22.4 KB (0%)
@sentry/react - Webpack 22.44 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.89 KB (0%)
@kamilogorek kamilogorek enabled auto-merge (squash) Jun 25, 2021
.github/workflows/build.yml Outdated Show resolved Hide resolved
kamilogorek and others added 2 commits Jul 1, 2021
@kamilogorek kamilogorek disabled auto-merge Jul 1, 2021
@kamilogorek kamilogorek enabled auto-merge (squash) Jul 1, 2021
@kamilogorek kamilogorek disabled auto-merge Jul 1, 2021
@kamilogorek kamilogorek merged commit ab0bc93 into master Jul 1, 2021
16 checks passed
16 checks passed
@github-actions
Install Dependencies
Details
@github-actions
Analyze (javascript)
Details
@github-actions
Build
Details
@github-actions
Size Check
Details
@github-actions
Lint
Details
@github-actions
Circular Dependency Check
Details
@github-actions
Test (Node 6)
Details
@github-actions
Test (Node 8)
Details
@github-actions
Test (Node 10)
Details
@github-actions
Test (Node 12)
Details
@github-actions
Test (Node 14)
Details
@github-actions
Test (Node 16)
Details
@github-actions
Test @sentry/ember Test @sentry/ember
Details
@github-actions
Upload Artifacts
Details
@github-actions
BrowserStack
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
@kamilogorek kamilogorek deleted the ember-cache-types branch Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants