Skip to content

update dicehub image addr#1171

Closed
ZLValien wants to merge 1 commit intoerda-project:masterfrom
ZLValien:feature/dicehub-image-api
Closed

update dicehub image addr#1171
ZLValien wants to merge 1 commit intoerda-project:masterfrom
ZLValien:feature/dicehub-image-api

Conversation

@ZLValien
Copy link
Contributor

What type of this PR

/kind feature

What this PR does / why we need it:

image service have been delete in endpoints.
provider open 8080 port

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1171 (75b817b) into master (e896ee3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
- Coverage   11.32%   11.32%   -0.01%     
==========================================
  Files         961      961              
  Lines       99918    99919       +1     
==========================================
  Hits        11316    11316              
- Misses      87581    87582       +1     
  Partials     1021     1021              
Impacted Files Coverage Δ
apistructs/org.go 0.00% <0.00%> (ø)
modules/dop/endpoints/issue_callback.go 0.00% <0.00%> (ø)

@ZLValien ZLValien added dop devops plaoform refactor labels Jul 28, 2021
@ZLValien ZLValien requested a review from sfwn July 28, 2021 12:46
- port: 10000
protocol: "TCP"
l4_protocol: "TCP"
- port: 8080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does image provider have invoker?

And you should add a global env DICEHUB_ADDR point to original addr for discover random-select issue.

@ZLValien ZLValien closed this Jul 29, 2021
@ZLValien ZLValien deleted the feature/dicehub-image-api branch August 19, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dop devops plaoform refactor

Development

Successfully merging this pull request may close these issues.

2 participants