Skip to content
#

design-system

Here are 1,018 public repositories matching this topic...

grommet
polaris-react
aurelienbobenrieth
aurelienbobenrieth commented Jun 3, 2021

Issue summary

selected prop for <Navigation.Item /> component is not working if url prop is not provided.

Expected behavior

Since it is not written in the doc that the url prop is required, using the selected prop without it should work just fine.
I wanted to use the onClick prop to handle my routing, combined with the selected prop for the UI, but it is not possible.

theme-ui
jayliu50
jayliu50 commented Mar 25, 2021

Is your feature request related to a problem? Please describe.
I spent many hours trying to override what I later found out was the highlight color variable, used in a number of Components in the code. I had no idea that this variable existed. :(

Describe the solution you'd like
Maybe just include the highlight default value in the base theme, so that developers building on that w

eui
components
emplums
emplums commented Dec 2, 2020

(moved over from https://github.com/github/design-systems/issues/860, thanks @smockle 👋 !)

Problem

Occasionally it’s useful to add an interactive element with the semantics of button (correctly represented in the AT)—but without its visual styles.

Solution

Other teams at GitHub spread the following object in sx props to destyle Buttons:

// Removes most of 'button'’s visual appearanc

Improve this page

Add a description, image, and links to the design-system topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the design-system topic, visit your repo's landing page and select "manage topics."

Learn more