Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of spaces for clone multi_options #1299

Conversation

Lakhtenkov-iv
Copy link
Contributor

@Lakhtenkov-iv Lakhtenkov-iv commented Jul 27, 2021

No description provided.

@Byron Byron added this to the v3.1.20 - Bugfixes milestone Jul 27, 2021
@Byron
Copy link
Member

@Byron Byron commented Jul 27, 2021

Thanks a lot, it's great to see it has a test, too.

@Byron Byron merged commit 254305c into gitpython-developers:main Jul 27, 2021
5 checks passed
@Lakhtenkov-iv Lakhtenkov-iv deleted the feature/clone-options-support-spaces branch Jul 27, 2021
@Lakhtenkov-iv
Copy link
Contributor Author

@Lakhtenkov-iv Lakhtenkov-iv commented Jul 27, 2021

Thanks @Byron for review.
Do you have ETA when you are going to release 3.1.20 that would fix yanked 3.1.19?

@Byron
Copy link
Member

@Byron Byron commented Jul 27, 2021

The next release happens once @Yobmod gives it a go, and I would expect that to happen during the weekend at the latest.

@Yobmod
Copy link
Contributor

@Yobmod Yobmod commented Jul 27, 2021

@Byron
Copy link
Member

@Byron Byron commented Jul 28, 2021

Thanks a million! As long as people are not showing up with pitchforks I suppose it's OK to release 3.1.20 and get feedback fast, possibly yanking the release if necessary. Those who can't have that will have pinned their version by now.

Since you have done so much work testing and found quite a few issues on the way I am also confident that there won't be any obvious flaws or side-effects this time.

v20 is out, let's hold our breath, I will keep the finger on the yank button, too :D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants