Skip to content

Fix typing of Head.create_head #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2021
Merged

Fix typing of Head.create_head #1302

merged 1 commit into from
Jul 31, 2021

Conversation

dimbleby
Copy link
Contributor

After creating a Head via Head.create_head(), mypy complains if I try to do head-like things with it:

error: "SymbolicReference" has no attribute "checkout"  
error: "SymbolicReference" has no attribute "set_tracking_branch"

@Byron Byron requested a review from Yobmod July 31, 2021 01:34
@Yobmod
Copy link
Contributor

Yobmod commented Jul 31, 2021

Hi, thanks for the fix!

@Yobmod Yobmod merged commit 9110b98 into gitpython-developers:main Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yobmod Yobmod Awaiting requested review from Yobmod

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimbleby @Yobmod