Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pie label margin doesn't exist on typing #14067

Closed
Ovilia opened this issue Jan 18, 2021 · 4 comments
Closed

Pie label margin doesn't exist on typing #14067

Ovilia opened this issue Jan 18, 2021 · 4 comments
Labels
bug doc en typescript
Milestone
5.0.2

Comments

@Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jan 18, 2021 •
edited

What problem does this feature solve?

When using in TypeScript projects, series[pie].label.margin gets the following error:

Type '{ position: "outer"; alignTo: "edge"; bleedMargin: number; margin: number; }' is not assignable to type 'PieLabelOption'.
  Object literal may only specify known properties, and 'margin' does not exist in type 'PieLabelOption'.ts(2322)

But this option takes effect, so just a problem of typing.

What is expected?

No type error.
@echarts-bot
Copy link

@echarts-bot echarts-bot bot commented Jan 18, 2021

Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.

In the meanwhile, please make sure that you have posted enough image to demo your request. You may also check out the API and chart option to get the answer.

If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.

If you are interested in the project, you may also subscribe our mailing list.

Have a nice day! 🍵

@Ovilia Ovilia added this to the 5.1.0 milestone Jan 18, 2021
@Ovilia
Copy link
Contributor Author

@Ovilia Ovilia commented Jan 18, 2021

margin seems to be renamed to edgeDistance. Document should be updated.

@pissang
Copy link
Contributor

@pissang pissang commented Jan 19, 2021

Updated the documents

@pissang pissang closed this Jan 19, 2021
@pissang pissang reopened this Jan 19, 2021
@pissang
Copy link
Contributor

@pissang pissang commented Jan 19, 2021

Should add back depracted options and add @deprecated mark

Ovilia added a commit that referenced this issue Jan 19, 2021
@Ovilia
fix(pie): deprecate series[pie].label.margin #14067
93e9fc8
@Ovilia Ovilia mentioned this issue Jan 19, 2021
Merged
5 tasks
Ovilia added a commit that referenced this issue Jan 19, 2021
@Ovilia
fix(pie): deprecate series[pie].label.margin #14067
392d94d
@Ovilia Ovilia closed this Jan 19, 2021
@pissang pissang removed this from the 5.1.0 milestone Jan 26, 2021
@pissang pissang added this to the 5.0.2 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug doc en typescript
Projects
None yet
Milestone
5.0.2
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Ovilia @pissang