Skip to content

/ tvm

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docker] Update tensorflow/tflite/xgboost versions #8306

Merged
merged 2 commits into from Jun 22, 2021
Merged

[Docker] Update tensorflow/tflite/xgboost versions #8306

merged 2 commits into from Jun 22, 2021

Conversation

@Lunderberg
Copy link
Contributor

@Lunderberg Lunderberg commented Jun 22, 2021

  • Updated tensorflow version to 2.4.2, required following update to cuda 11.0. Based on https://www.tensorflow.org/install/source#gpu, the 2.4 branch of tensorflow should be used with cuda 11.0.

  • Removed pinned version of h5py, no longer needed with tensorflow 2.4.x

    tensorflow/tensorflow#44467 (comment)

  • Updated tflite version to 2.4.2. Also, tflite install script now reads the installed version of tensorflow, to keep the version matched in the future.

  • Previously, due to missing quotes, installed most recent version of xgboost, piping the results to a file named '=1.1.0'. Now, installs xgboost at least at version 1.1.0.
Eric Lunderberg added 2 commits Jun 22, 2021
Eric Lunderberg
[Docker] Updated tensorflow/tflite version to 2.4.2
b3f90ab 
Tensorflow update required following update to cuda 11.0.  Based on
https://www.tensorflow.org/install/source#gpu, the 2.4 branch of
tensorflow should be used with cuda 11.0.

- Removed pinned version of keras/h5py, no longer needed.

  tensorflow/tensorflow#44467 (comment)

- Updated tflite version to 2.4.2.  Also, tflite install script now
  reads the installed version of tensorflow, to keep the version
  matched in the future.
Eric Lunderberg
[Docker] Corrected version pinning of xgboost
89adbc0 
Previously, due to missing quotes, installed most recent version of
xgboost, piping the results to a file named '=1.1.0'.  Now, installs
xgboost at least at version 1.1.0.
@Lunderberg
Copy link
Contributor Author

@Lunderberg Lunderberg commented Jun 22, 2021

@mbrookhart
@Lunderberg Lunderberg mentioned this pull request Jun 22, 2021
Closed
26 tasks done
@mbrookhart
mbrookhart approved these changes Jun 22, 2021
View changes
@mbrookhart mbrookhart merged commit 9f350d3 into apache:main Jun 22, 2021
3 checks passed
3 checks passed
@github-actions
Build (windows-2016)
Details
@github-actions
Build (macOS-latest)
Details
@tqchen
tvm-ci/pr-merge This commit looks good
Details
@mbrookhart
Copy link
Contributor

@mbrookhart mbrookhart commented Jun 22, 2021

Thanks @Lunderberg
@Lunderberg Lunderberg deleted the Lunderberg:ci_image_versions branch Jun 23, 2021
@manupa-arm manupa-arm mentioned this pull request Jun 23, 2021
Merged
@manupa-arm
Copy link
Contributor

@manupa-arm manupa-arm commented Jun 23, 2021 •
edited

Before merging changes to install scripts, would it be possible to check whether docker images that uses scripts can be built ?
In this case, ci_cpu will not build because tensorflow is installed after tflite is installed.

We have created a PR to fix this for now : #8312

cc : @leandron @areusch
@mbrookhart
Copy link
Contributor

@mbrookhart mbrookhart commented Jun 23, 2021

This was my fault, I'm sorry. The Ubuntu repository for llvm was broken yesterday, so the docker build failed for unrelated reasons before I hit this, I should have waited
Lunderberg pushed a commit to Lunderberg/tvm that referenced this pull request Jun 23, 2021
Eric Lunderberg
[Docker] Fix ordering of tf and tflite installs in ci_qemu
bb2333e 
Similar to apache#8312, the recently merged apache#8306 required tflite to be
installed after tf.  However, apache#8306 did not correct the ordering in
the dockerfiles.  After this and apache#8312, all dockerfiles should be up
to date with the correct ordering.
@Lunderberg Lunderberg mentioned this pull request Jun 23, 2021
Merged
Lunderberg pushed a commit to Lunderberg/tvm that referenced this pull request Jun 23, 2021
Eric Lunderberg
[Docker] Fix ordering of tf and tflite installs in ci_qemu
dd0e0f0 
Similar to apache#8312, the recently merged apache#8306 required tflite to be
installed after tf.  However, apache#8306 did not correct the ordering in
the dockerfiles.  After this and apache#8312, all dockerfiles should be up
to date with the correct ordering.
Lunderberg pushed a commit to Lunderberg/tvm that referenced this pull request Jun 24, 2021
Eric Lunderberg
[Docker] Fix ordering of tf and tflite installs in ci_qemu
1cb28e9 
Similar to apache#8312, the recently merged apache#8306 required tflite to be
installed after tf.  However, apache#8306 did not correct the ordering in
the dockerfiles.  After this and apache#8312, all dockerfiles should be up
to date with the correct ordering.
@manupa-arm manupa-arm mentioned this pull request Jun 25, 2021
Open
mbrookhart pushed a commit that referenced this pull request Jun 25, 2021
@Lunderberg Eric Lunderberg
[Docker] Fix ordering of tf and tflite installs in ci_qemu (#8315)
70183ed 
Similar to #8312, the recently merged #8306 required tflite to be
installed after tf.  However, #8306 did not correct the ordering in
the dockerfiles.  After this and #8312, all dockerfiles should be up
to date with the correct ordering.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookhart mbrookhart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Lunderberg @mbrookhart @manupa-arm