Skip to content

/ berty

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigate instead of erroring on contact already added #3451

Open
n0izn0iz opened this issue Jul 21, 2021 · 0 comments
Open

Navigate instead of erroring on contact already added #3451

n0izn0iz opened this issue Jul 21, 2021 · 0 comments
Labels
echoes/users good first issue

Comments

@n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Jul 21, 2021 •
edited

When a contact is already added, open the contact profile or the existant conversation

The error check is done here:

berty/js/packages/components/modals/InvalidScan.tsx

Line 126 in 097eb02

const isContactAlreadyAdded = error?.error?.errorDetails?.codes?.includes(

We shouldn't show the invalid scan modal but navigate instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
echoes/users good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@n0izn0iz