Skip to content

/ origin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"A review has been left on your transaction" email sent to reviewer #4359

Open
lucadgtrip opened this issue Feb 20, 2020 · 3 comments · May be fixed by #4426
Open

"A review has been left on your transaction" email sent to reviewer #4359

lucadgtrip opened this issue Feb 20, 2020 · 3 comments · May be fixed by #4426
Assignees
@fedealconada
Labels
P2 good first issue notifications

Comments

@lucadgtrip
Copy link

@lucadgtrip lucadgtrip commented Feb 20, 2020

I left a review and then got this message

Screenshot 2020-02-20 at 16 23 50

which seems strange as it's telling me something I know.
@franckc
Copy link
Member

@franckc franckc commented Feb 24, 2020

The logic deciding what emails to send is here.

We should review it to make sure it makes sense.
@rembrandtreyes
Copy link
Member

@rembrandtreyes rembrandtreyes commented Feb 26, 2020

@franckc Yeah looks like we have it reversed. We should flip this to the seller side. Or for two-way visibility, we change the language of this email to be something like, "Your review has been posted to the seller's listing."

I'll review the other email flows to make sure they all make sense.
@fedealconada
Copy link

@fedealconada fedealconada commented Apr 6, 2020

I'll grab this one if possible @rembrandtreyes
@fedealconada fedealconada linked a pull request that will close this issue Apr 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedealconada fedealconada

Labels
P2 good first issue notifications
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

[WIP][GH-4359] fix wrong email notification after leaving review
4 participants
@franckc @fedealconada @rembrandtreyes @lucadgtrip