Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing nuget.config files #7544

Merged
merged 15 commits into from Apr 7, 2021

Conversation

@AgneLukoseviciute
Copy link
Contributor

@AgneLukoseviciute AgneLukoseviciute commented Apr 6, 2021

Adding nuget.config files for e2e-test-app and integration-test-app. This should hopefully unblock the CI builds.

Microsoft Reviewers: Open in CodeFlow
@AgneLukoseviciute AgneLukoseviciute requested a review from microsoft/react-native-windows-write as a code owner Apr 6, 2021
@dannyvv
dannyvv approved these changes Apr 6, 2021
@AgneLukoseviciute
Copy link
Contributor Author

@AgneLukoseviciute AgneLukoseviciute commented Apr 7, 2021

That fixed E2E-, but only partially helped Integration-test. Looks like something's up with dependencies for folly, @dannyvv @asklar any ideas?

@asklar
Copy link
Member

@asklar asklar commented Apr 7, 2021

@AgneLukoseviciute It's unclear why some projects are ok and why some aren't. From what I can see, nuget.org is mentioned in the list of sources used towards the end, so this seems like something is broken with either the nuget task (i.e. it's not using the nuget from VS but instead it's using a custom nuget.exe that is incompatible), or the nuget.exe in VS is broken in recent builds.
Can you try running nuget sources before running the build or restores? That seemed to nudge another repo into picking the right nuget.exe. Also might want to look at running NugetToolInstall. If none of this works, please start a thread with VS Discussions or 1ES to figure out why we're still broken despite having a nuget.config.

@jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Apr 7, 2021

Why are we dealing with nuget.exe at all in this yml? We build the app with run-windows, which restores the nuget packages we need. And if that doesn't work, then we need to fix run-windows.

@dannyvv
Copy link
Member

@dannyvv dannyvv commented Apr 7, 2021

Why are we dealing with nuget.exe at all in this yml? We build the app with run-windows, which restores the nuget packages we need. And if that doesn't work, then we need to fix run-windows.

@jonthysell
Agree we should fix the underlying issue, but I'd say higher priority is getting us unblocked and have code flowing again.
Note they only issue seems to be on the ADO/GH hosted agents where they changed some defaults that used to work. On local dev boxes there is still the default fallback. Note that Asklar also has a draft PR out to add nuget.config files to templates.

@NickGerleman
Copy link
Contributor

@NickGerleman NickGerleman commented Apr 7, 2021

Has anyone tried the workaround mentioned in #7436

Register-PackageSource -Name MyNuGet -Location https://www.nuget.org/api/v2 -ProviderName NuGet -Trusted

@AgneLukoseviciute
Copy link
Contributor Author

@AgneLukoseviciute AgneLukoseviciute commented Apr 7, 2021

Has anyone tried the workaround mentioned in #7436

Register-PackageSource -Name MyNuGet -Location https://www.nuget.org/api/v2 -ProviderName NuGet -Trusted

Haven't tried that here yet. I just added a nuget.config in the root of the repo as suggested fix in another thread, if this doesn't work I'll give that a shot.

@jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Apr 7, 2021

I've rekicked this off since GH and ADO were out of sync. Hopefully now we'll get the pass.

@jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Apr 7, 2021

The Folly project is still not seeing boost.

@dannyvv
Copy link
Member

@dannyvv dannyvv commented Apr 7, 2021

@jonthysell : The error is in the nuget packages path:
error: D:\a\1\s\packages\integration-test-app\windows\packages\boost.1.72.0.0\build\boost.targets
where nuget places the file at: Adding package 'boost.1.72.0' to folder 'D:\a\1\s\packages\integration-test-app\packages'
Due to the new nuget config having:

  <config>
    <add key="repositoryPath" value="packages" />
  </config>

which should probably be windows/packages which makes me confused how in e2e it does resolve to the right path... This nuget config merging is pretty opaque and non-intuitive....

@jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Apr 7, 2021

@jonthysell Jon Thysell (JAUNTY) FTE : The error is in the nuget packages path:
error: D:\a\1\s\packages\integration-test-app\windows\packages\boost.1.72.0.0\build\boost.targets
where nuget places the file at: Adding package 'boost.1.72.0' to folder 'D:\a\1\s\packages\integration-test-app\packages'
Due to the new nuget config having:

  <config>
    <add key="repositoryPath" value="packages" />
  </config>

which should probably be windows/packages which makes me confused how in e2e it does resolve to the right path... This nuget config merging is pretty opaque and non-intuitive....

Lol, I just saw the same thing. The nuget.config should fix things, it just needs to be put into the windows folder. The e2e isn't resolving it to the right path, it's failing too. GH and ADO were out of sync. both failed in ADO but in GH it shows one as passed and the other as still running.

@AgneLukoseviciute
Copy link
Contributor Author

@AgneLukoseviciute AgneLukoseviciute commented Apr 7, 2021

/azp run

@azure-pipelines
Copy link

@azure-pipelines azure-pipelines bot commented Apr 7, 2021

Azure Pipelines successfully started running 1 pipeline(s).
@AgneLukoseviciute AgneLukoseviciute merged commit cbad980 into microsoft:master Apr 7, 2021
35 checks passed
35 checks passed
@azure-pipelines
PR Build #RNW_0.0.0-canary.286.pr154231 succeeded
Details
@azure-pipelines
PR (Build 🔨 Desktop X64Debug) Build 🔨 Desktop X64Debug succeeded
Details
@azure-pipelines
PR (Build 🔨 Desktop X64Release) Build 🔨 Desktop X64Release succeeded
Details
@azure-pipelines
PR (Build 🔨 Desktop X86Debug) Build 🔨 Desktop X86Debug succeeded
Details
@azure-pipelines
PR (Build 🔨 Pack Desktop NuGet Package) Build 🔨 Pack Desktop NuGet Package succeeded
Details
@azure-pipelines
PR (Build 🔨 Universal Build X64ReleaseFast) Build 🔨 Universal Build X64ReleaseFast succeeded
Details
@azure-pipelines
PR (Build 🔨 Universal Build X86DebugFast) Build 🔨 Universal Build X86DebugFast succeeded
Details
@azure-pipelines
PR (Build 🔨 Universal Build 🏗) Build 🔨 Universal Build 🏗 succeeded
Details
@azure-pipelines
PR (Build 🔨 Universal Test X64ReleaseFast) Build 🔨 Universal Test X64ReleaseFast succeeded
Details
@azure-pipelines
PR (Build 🔨 Universal Test X86DebugFast) Build 🔨 Universal Test X86DebugFast succeeded
Details
@azure-pipelines
PR (Build 🔨 Verify Cli X64DebugCppNuget) Build 🔨 Verify Cli X64DebugCppNuget succeeded
Details
@azure-pipelines
PR (Build 🔨 Verify Cli X64DebugCsNuget) Build 🔨 Verify Cli X64DebugCsNuget succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X64ReleaseCpp) Cli 🖥 Verify Cli X64ReleaseCpp succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X64ReleaseCppHermes) Cli 🖥 Verify Cli X64ReleaseCppHermes succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X64ReleaseCs) Cli 🖥 Verify Cli X64ReleaseCs succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X86DebugCpp) Cli 🖥 Verify Cli X86DebugCpp succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X86DebugCppHermes) Cli 🖥 Verify Cli X86DebugCppHermes succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X86DebugCppLib) Cli 🖥 Verify Cli X86DebugCppLib succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X86DebugCppWinUI3) Cli 🖥 Verify Cli X86DebugCppWinUI3 succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X86DebugCs) Cli 🖥 Verify Cli X86DebugCs succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X86DebugCsLib) Cli 🖥 Verify Cli X86DebugCsLib succeeded
Details
@azure-pipelines
PR (Cli 🖥 Verify Cli X86DebugCsWinUI3) Cli 🖥 Verify Cli X86DebugCsWinUI3 succeeded
Details
@azure-pipelines
PR (Setup Setup) Setup Setup succeeded
Details
@azure-pipelines
PR (Tests 🧪 E2E Test App x86) Tests 🧪 E2E Test App x86 succeeded
Details
@azure-pipelines
PR (Tests 🧪 Integration Test App X64) Tests 🧪 Integration Test App X64 succeeded
Details
@azure-pipelines
PR (Tests 🧪 JavaScript Checks) Tests 🧪 JavaScript Checks succeeded
Details
@azure-pipelines
PR (Tests 🧪 Playground X64ReleaseUniversal) Tests 🧪 Playground X64ReleaseUniversal succeeded
Details
@azure-pipelines
PR (Tests 🧪 Playground X64ReleaseWin32) Tests 🧪 Playground X64ReleaseWin32 succeeded
Details
@azure-pipelines
PR (Tests 🧪 Playground X86DebugUniversal) Tests 🧪 Playground X86DebugUniversal succeeded
Details
@azure-pipelines
PR (Tests 🧪 Playground X86DebugWin32) Tests 🧪 Playground X86DebugWin32 succeeded
Details
@azure-pipelines
PR (Tests 🧪 Playground X86DebugWinUI3) Tests 🧪 Playground X86DebugWinUI3 succeeded
Details
@azure-pipelines
PR (Tests 🧪 Sample Apps X64Release) Tests 🧪 Sample Apps X64Release succeeded
Details
@azure-pipelines
PR (Tests 🧪 Sample Apps X86Debug) Tests 🧪 Sample Apps X86Debug succeeded
Details
@azure-pipelines
PR (Tests 🧪 macOS Tests) Tests 🧪 macOS Tests succeeded
Details
@microsoft-cla
license/cla All CLA requirements met.
Details
@AgneLukoseviciute AgneLukoseviciute deleted the AgneLukoseviciute:nugetconfigs branch Apr 7, 2021
This was referenced Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants