Skip to content

/ gonum

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bound: add Bound package and type #845

Merged
merged 2 commits into from Feb 10, 2019
Merged

bound: add Bound package and type #845

merged 2 commits into from Feb 10, 2019

Conversation

@btracey
Copy link
Member

@btracey btracey commented Feb 10, 2019 •
edited

Updates #833.

Please take a look.
@btracey
bound: add Bound type
Loading status checks…
ca6fbcc 
Fixes 833.
@btracey btracey requested review from kortschak, sbinet and vladimir-ch Feb 10, 2019
@kortschak
kortschak reviewed Feb 10, 2019
View changes
bound/bound.go Outdated

// Bound represents [Min, Max] bounds.
type Bound struct {
Min float64

This comment has been minimized.

Sign in to view
@kortschak

kortschak Feb 10, 2019
Member

Do these need to be on different lines?

This comment has been minimized.

Sign in to view
@btracey

btracey Feb 10, 2019
Author Member

No
bound/doc.go Show resolved Hide resolved
@btracey
respond to PR comment
Loading status checks…
1918343
@btracey btracey mentioned this pull request Feb 10, 2019
Closed
@kortschak
kortschak approved these changes Feb 10, 2019
View changes
@btracey btracey merged commit db51563 into master Feb 10, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@btracey btracey deleted the bound branch Feb 10, 2019
@btracey btracey mentioned this pull request Mar 30, 2019
Open
@kortschak kortschak mentioned this pull request May 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kortschak kortschak

@sbinet sbinet

@vladimir-ch vladimir-ch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@btracey @kortschak
You can’t perform that action at this time.