Simplify {OS,Processor}Architecture on Unix #57172
Open
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR defines
TARGET_{arch}constant inSystem.Runtime.InteropServices.RuntimeInformation.csprojbased onTargetArchitecturedefined in the top-levelDirectory.Build.props; and uses the defined constant to set values forProcessorArchitectureandOSArchitectureproperties at build-time on Unix-like platforms.With this approach the interop overhead to get the architecture value from PAL goes away, which was defining these values with similar mechanism.
Closes #57152