Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLine breaks for multi-entry array #1733
Open
Conversation
Description states, "Use line breaks after open and before close array brackets if an array has multiple lines," which would imply the form reflected in the edit. If the intention was actually to list the array as 'const arr = [[0, 1], [2, 3], [4, 5]];' a caveat should be added to 4.7 description, since it doesn't involve a line break after the opening or before the closing brackets.
| @@ -460,7 +460,11 @@ Other Style Guides | |||
| ]; | |||
| // good | |||
| const arr = [[0, 1], [2, 3], [4, 5]]; | |||
| const arr = [ | |||
This comment has been minimized.
This comment has been minimized.
ljharb
Feb 18, 2018
Collaborator
this is intentional; this array doesn't have multiple lines, so there's no need to use line breaks - that's why it's a "good" example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jfdnc commentedFeb 18, 2018
Description states, "Use line breaks after open and before close array brackets if an array has multiple lines," which would imply the form reflected in the edit. If the intention was actually to list the array as 'const arr = [[0, 1], [2, 3], [4, 5]];' a caveat should be added to 4.7 description, since it doesn't involve a line break after the opening or before the closing brackets.