Skip to content

/ swc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix bugs and implement more rules #2032

Merged
merged 27 commits into from Aug 8, 2021
Merged

fix(es/minifier): Fix bugs and implement more rules #2032

merged 27 commits into from Aug 8, 2021

Conversation

@kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 8, 2021 •
edited

swc_ecma_minifier:

  • Fix an infinite loop. (Closes #2028)
  • Don't remove span hygiene. (Closes #2022)

swc_ecma_codegen:

  • Fix codegen of return with async arrow. (Closes #2020)

swc:

  • Respect minify = false. (Closes #2019)
kdy1 added 6 commits Aug 8, 2021
@kdy1
Add a test for #2028
5cc50a6
@kdy1
Add config.json
ac1cec1
@kdy1
Log level
8cf056a
@kdy1
Track if we are in topmost expr
96248fc
@kdy1
Fix #2028
238565a
@kdy1
Update test refs
45ce813
@kdy1 kdy1 added this to the v1.2.75 milestone Aug 8, 2021
kdy1 added 15 commits Aug 8, 2021
@kdy1
Add a test for #2022
b84c442
@kdy1
More tests for #2022
819c996
@kdy1
fixup
d04860a
@kdy1
Update test refs
1096f43
@kdy1
Fix #2022
34378af
@kdy1
Update test refs
f4db995
@kdy1
Merge branch 'master' into minifier-rules
9b4469a
@kdy1
Add a test for #2020
9a1dcc6
@kdy1
Fix codegen of return async
ef5846d
@kdy1
Update test refs
f83dcbc
@kdy1
Bump verison
38b208c
@kdy1
Bump version
6716817
@kdy1
Add a test for #2019
c862d0c
@kdy1
Fix #2019
8db9fda
@kdy1
Bump version
ba4bf4c
@kdy1 kdy1 marked this pull request as ready for review Aug 8, 2021
@kdy1 kdy1 enabled auto-merge (squash) Aug 8, 2021
@kdy1 kdy1 disabled auto-merge Aug 8, 2021
kdy1 added 5 commits Aug 8, 2021
@kdy1
Fix test
e3e5b40
@kdy1
Merge branch 'master' into minifier-rules
13838f9
@kdy1
Update test refs
83c615a
@kdy1
Update test refs
23ad0bd
@kdy1
Update test refs
c5f8ddd
@kdy1
Change test
3289bfb
@kdy1 kdy1 enabled auto-merge (squash) Aug 8, 2021
@kdy1 kdy1 merged commit 9793926 into swc-project:master Aug 8, 2021
100 checks passed
100 checks passed
@github-actions
Binary size
Details
@github-actions
Check license
Details
@github-actions
compilation
Details
@github-actions
node-api
Details
@github-actions
Performance regression check Performance regression check
Details
@github-actions
fmt
Details
@github-actions
swc-cli
Details
@github-actions
Check (ubuntu-latest)
Details
@github-actions
Check (macos-10.15)
Details
@github-actions
Check (windows-latest)
Details
@github-actions
Docs
Details
@github-actions
Test (ubuntu-latest, ast_node)
Details
@github-actions
Test (ubuntu-latest, enum_kind)
Details
@github-actions
Test (ubuntu-latest, from_variant)
Details
@github-actions
Test (ubuntu-latest, jsdoc)
Details
@github-actions
Test (ubuntu-latest, node)
Details
@github-actions
Test (ubuntu-latest, spack)
Details
@github-actions
Test (ubuntu-latest, string_enum)
Details
@github-actions
Test (ubuntu-latest, swc)
Details
@github-actions
Test (ubuntu-latest, swc_atoms)
Details
@github-actions
Test (ubuntu-latest, swc_babel_ast)
Details
@github-actions
Test (ubuntu-latest, swc_babel_compat)
Details
@github-actions
Test (ubuntu-latest, swc_babel_visit)
Details
@github-actions
Test (ubuntu-latest, swc_bundler)
Details
@github-actions
Test (ubuntu-latest, swc_common)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_ast)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_codegen)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_codegen_macros)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_dep_graph)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_ext_transforms)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_loader)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_minifier)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_parser)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_preset_env)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_base)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_classes)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_compat)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_macros)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_module)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_optimization)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_proposal)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_react)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_testing)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_transforms_typescript)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_utils)
Details
@github-actions
Test (ubuntu-latest, swc_ecma_visit)
Details
@github-actions
Test (ubuntu-latest, swc_ecmascript)
Details
@github-actions
Test (ubuntu-latest, swc_eq_ignore_macros)
Details
@github-actions
Test (ubuntu-latest, swc_macros_common)
Details
@github-actions
Test (ubuntu-latest, swc_node_base)
Details
@github-actions
Test (ubuntu-latest, swc_visit)
Details
@github-actions
Test (ubuntu-latest, swc_visit_macros)
Details
@github-actions
Test (ubuntu-latest, testing)
Details
@github-actions
Test (ubuntu-latest, testing_macros)
Details
@github-actions
Test (ubuntu-latest, wasm)
Details
@github-actions
Test (windows-latest, ast_node)
Details
@github-actions
Test (windows-latest, enum_kind)
Details
@github-actions
Test (windows-latest, from_variant)
Details
@github-actions
Test (windows-latest, jsdoc)
Details
@github-actions
Test (windows-latest, node)
Details
@github-actions
Test (windows-latest, string_enum)
Details
@github-actions
Test (windows-latest, swc)
Details
@github-actions
Test (windows-latest, swc_atoms)
Details
@github-actions
Test (windows-latest, swc_babel_ast)
Details
@github-actions
Test (windows-latest, swc_babel_compat)
Details
@github-actions
Test (windows-latest, swc_babel_visit)
Details
@github-actions
Test (windows-latest, swc_bundler)
Details
@github-actions
Test (windows-latest, swc_common)
Details
@github-actions
Test (windows-latest, swc_ecma_ast)
Details
@github-actions
Test (windows-latest, swc_ecma_codegen)
Details
@github-actions
Test (windows-latest, swc_ecma_codegen_macros)
Details
@github-actions
Test (windows-latest, swc_ecma_dep_graph)
Details
@github-actions
Test (windows-latest, swc_ecma_ext_transforms)
Details
@github-actions
Test (windows-latest, swc_ecma_loader)
Details
@github-actions
Test (windows-latest, swc_ecma_minifier)
Details
@github-actions
Test (windows-latest, swc_ecma_parser)
Details
@github-actions
Test (windows-latest, swc_ecma_preset_env)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_base)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_classes)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_compat)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_macros)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_module)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_optimization)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_proposal)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_react)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_testing)
Details
@github-actions
Test (windows-latest, swc_ecma_transforms_typescript)
Details
@github-actions
Test (windows-latest, swc_ecma_utils)
Details
@github-actions
Test (windows-latest, swc_ecma_visit)
Details
@github-actions
Test (windows-latest, swc_ecmascript)
Details
@github-actions
Test (windows-latest, swc_eq_ignore_macros)
Details
@github-actions
Test (windows-latest, swc_macros_common)
Details
@github-actions
Test (windows-latest, swc_node_base)
Details
@github-actions
Test (windows-latest, swc_visit)
Details
@github-actions
Test (windows-latest, swc_visit_macros)
Details
@github-actions
Test (windows-latest, testing)
Details
@github-actions
Test (windows-latest, testing_macros)
Details
@github-actions
Test (windows-latest, wasm)
Details
@kdy1 kdy1 deleted the kdy1:minifier-rules branch Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.2.75
Linked issues

Successfully merging this pull request may close these issues.

Infinite loop detected (current pass = 31)', ecmascript/minifier/src/compress/mod.rs:229:13
bug(minify): parameters with default value minified to same name
minify: problem with returnasync
minify: works regardless of settings
1 participant
@kdy1