[qa] add css linting to run qa-checks #373#376
Conversation
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Can you please add a stylelint configuration like the one we have in ow-notifications and ensure the build passes?
|
Sure, I'll do that. |
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Sorry for my delayed response, I merged the latest master and resolved the conflict but the build is still failing, could you fix it? See also my comment below.
| ], | ||
| "unit-allowed-list": ["em", "rem", "%", "s", "px", "vh", "deg", "pt"] | ||
| } | ||
| } |
There was a problem hiding this comment.
the indentation of this file is odd, can you ensure it uses 4 spaces please?
There was a problem hiding this comment.
It's already 4 spaces when viewed in my IDE. I don't know why indentation changes when pushed to GitHub.
There was a problem hiding this comment.
it's because it's using tabs instead of spaces, I suggest enabling the "show white space option in your editor" so you can see this. Can you change from tabs to spaces please? We do this for consistency with the rest of the codebase which uses only spaces.
totallynotvaishnav
force-pushed
the
373-css-linting-to-run-qa-checks
branch
4 times, most recently
from
2e57179 to
7045cd1
Compare
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Did some testing and everything is fine, almost ready, see my comment below for the last thing.
| ], | ||
| "unit-allowed-list": ["em", "rem", "%", "s", "px", "vh", "deg", "pt"] | ||
| } | ||
| } |
There was a problem hiding this comment.
it's because it's using tabs instead of spaces, I suggest enabling the "show white space option in your editor" so you can see this. Can you change from tabs to spaces please? We do this for consistency with the rest of the codebase which uses only spaces.
Fixes openwisp#373 change indentation from tabs to spaces
totallynotvaishnav
force-pushed
the
373-css-linting-to-run-qa-checks
branch
from
1d4186c to
985cb81
Compare
3 participants
Fixes #373