Merged
Conversation
Member
|
Any possibility that we can squash commits before merge again? |
Member
Author
Yes! Sorry if the number of commits was excessive. My intention was to have relatively self-contained changes in each commit. And since the different commits add completely unrelated changes, I left them as individual commits. But I can squash next time if its preferred! |
Member
|
Well its not a strict law, you know, but sort of good practice. And if it really is thematically three things, then three commits it is. If its three larger topics then it should probably be also three individual PRs. Whatever makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a number of small, self-contained improvements. The changes are:
lib/cpp/src/thrift/transport/TBufferTransports.h: Minor whitespace changes
TSocket.cpp: Print THRIFT_EAGAIN (timed out) to global error
build/cmake/DefineOptions.cmake: Minor improvement in logging for 'WITH_MT'
lib/cpp/test/CMakeLists.txt: Added missing boost::chrono
build/cmake/BoostMacros.cmake: Removed 'Boost_NO_BOOST_CMAKE' and minor cleanup
TCompactProtocol.tcc: add missing include cstdlib
Include signal.h depending on HAVE_SIGNAL_H, not depending on linux
Added new method isUnixDomainSocket() to check type of socket
No Apache Jira ticket for trivial changes
If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
Changes are not squashed, to keep the consistency of each change
Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
If your change does not involve any code, include
[skip ci]anywhere in the commit message to free up build resources.