Skip to content

Several diverse improvements#2437

Merged
emmenlau merged 8 commits intoapache:masterfrom
BioDataAnalysis:bda_several_improvements
Aug 13, 2021
Merged

Several diverse improvements#2437
emmenlau merged 8 commits intoapache:masterfrom
BioDataAnalysis:bda_several_improvements

Conversation

@emmenlau
Copy link
Copy Markdown
Member

This PR contains a number of small, self-contained improvements. The changes are:

  • lib/cpp/src/thrift/transport/TBufferTransports.h: Minor whitespace changes

  • TSocket.cpp: Print THRIFT_EAGAIN (timed out) to global error

  • build/cmake/DefineOptions.cmake: Minor improvement in logging for 'WITH_MT'

  • lib/cpp/test/CMakeLists.txt: Added missing boost::chrono

  • build/cmake/BoostMacros.cmake: Removed 'Boost_NO_BOOST_CMAKE' and minor cleanup

  • TCompactProtocol.tcc: add missing include cstdlib

  • Include signal.h depending on HAVE_SIGNAL_H, not depending on linux

  • Added new method isUnixDomainSocket() to check type of socket

  • No Apache Jira ticket for trivial changes

  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?

  • Changes are not squashed, to keep the consistency of each change

  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?

  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@emmenlau emmenlau merged commit a142709 into apache:master Aug 13, 2021
@Jens-G
Copy link
Copy Markdown
Member

Jens-G commented Aug 30, 2021

Any possibility that we can squash commits before merge again?

@emmenlau emmenlau deleted the bda_several_improvements branch August 30, 2021 22:52
@emmenlau
Copy link
Copy Markdown
Member Author

Any possibility that we can squash commits before merge again?

Yes! Sorry if the number of commits was excessive. My intention was to have relatively self-contained changes in each commit. And since the different commits add completely unrelated changes, I left them as individual commits. But I can squash next time if its preferred!

@Jens-G
Copy link
Copy Markdown
Member

Jens-G commented Aug 31, 2021

Well its not a strict law, you know, but sort of good practice. And if it really is thematically three things, then three commits it is. If its three larger topics then it should probably be also three individual PRs. Whatever makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants