Hi @shubham9411!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Comparing: 34308b5...f103c6d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f103c6d

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Nice. Thanks!

Oops. CI is failing and saying that you need to run this script locally:

replace-fork

I'm not sure why this is, since you didn't touch reconciler code. Can you rebase on main to rule that out?

Hi @bvaughn, I rebased this PR with main and ran yarn replace-fork and it still changed the reconciler files.
I checked and found that CI is failing because of changes in fixtures/flight/config/webpack.config.js file. If i change this file it fails yarn linc --fix inside yarn replace-fork with this error:

Error: Failed to load config "react-app" to extend from.
Referenced from: /Users/x/y/z/react/fixtures/flight/package.json
...
...
messageTemplate: 'extend-config-missing',
  messageData: {
    configName: 'react-app',
    importerName: '/Users/x/y/z/react/fixtures/flight/package.json'
  }
}

I am confused should I change that file back or fix this first 😬

Edit: For now I have removed that file change.