Skip to content

Comments

feat: Adding fibonacci triangle program#723

Closed
sumeet-shinde wants to merge 19 commits intoTheAlgorithms:masterfrom
sumeet-shinde:master
Closed

feat: Adding fibonacci triangle program#723
sumeet-shinde wants to merge 19 commits intoTheAlgorithms:masterfrom
sumeet-shinde:master

Conversation

@sumeet-shinde
Copy link

@sumeet-shinde sumeet-shinde commented Oct 26, 2020

Program to print Fibonacci series in triangle

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@lgtm-com

This comment has been minimized.

@sumeet-shinde sumeet-shinde reopened this Oct 26, 2020
@Panquesito7 Panquesito7 added the enhancement New feature or request label Oct 27, 2020
@Panquesito7
Copy link
Member

Please fix the warning reported by LGTM.

@sumeet-shinde
Copy link
Author

I have fixed it...

@sumeet-shinde
Copy link
Author

It has passed all checks

#include<stdlib.h>
#include<assert.h>
/**
* funtion to print fibonacci series in traingle format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing parameter n documentation.

sumeet-shinde and others added 8 commits October 27, 2020 22:53
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@sumeet-shinde
Copy link
Author

Changes updated

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable GitHub Actions in your repository of this fork in this link: https://github.com/sumeet-shinde/C/actions

sumeet-shinde and others added 3 commits October 28, 2020 10:11
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@github-actions github-actions bot force-pushed the master branch 2 times, most recently from f4d49ec to b8a00ea Compare October 28, 2020 04:43
@sumeet-shinde
Copy link
Author

changes updated

@Panquesito7 Panquesito7 changed the title Adding fibonacci triangle program feat: Adding fibonacci triangle program Oct 30, 2020
sumeet-shinde and others added 2 commits October 30, 2020 20:21
Co-authored-by: David Leal <halfpacho@gmail.com>
sumeet-shinde and others added 3 commits October 31, 2020 10:59
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@github-actions github-actions bot force-pushed the master branch 2 times, most recently from 95de243 to 02a3ea3 Compare October 31, 2020 05:31
#include <stdio.h> /// for standard Input Output
#include <stdlib.h> /// for standard library functions
#include <assert.h> /// for assert functions
#include <stdbool.h> /// for boolean functions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <stdbool.h> /// for boolean functions
#include <stdbool.h> /// for boolean functions

@github-actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Oct 15, 2021
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants