Skip to content
#

Rails

rails logo

Ruby on Rails (Rails) is a web application framework written in Ruby. It is meant to help simplify the building of complex websites.

Here are 9,140 public repositories matching this topic...

spree
ronzalo
ronzalo commented Aug 7, 2020

Context

I've create a custom action that redirect to cart page with a success flash, but page open no-product-available modal

Expected Behavior

Show modal only if applies

Actual Behavior

Cart page open a modal if there are a flash, no matter if is success or error

Possible Fix

Fix this view https://github.com/spree/spree/blob/a7f7114d3237ad214aacc9fe96d1676f1c115976/fron

eliotsykes
eliotsykes commented Oct 3, 2019

I'm sorry to post an issue that is missing crucial evidence, but some debugging of a recent config loading bug makes me suspect that the react-rails railtie.rb may be modifying the load order of initializers, and preventing the values in Rails.application.config being as expected.

Whether this happens or not appears to be partly dependent on where in the Gemfile the react-rails gem is l

fiedl
fiedl commented May 8, 2017

I'm not sure if this is the right approach and maybe I've not understood this new part of the pipeline, yet, but:

Suppose, the major part of the app code lives inside a rails engine including all javascripts. And there are several main apps using that engine. The main apps only contain some layout changes and some minor patches.

Therefore, in order to integrate the webpacker gem into this se

PragTob
PragTob commented Jul 5, 2020

We have a problem: if files aren't loaded/required we don't have branch data. If they are added through track_files we give it 0/0 branches which we show as 100% coverage (all possible branches are covered).

That math is "wrong" though here because there are branches but we don't know what they are. We should probably count total branches here as "unkown" and establish that in our "math unive

solidus
kennyadsl
kennyadsl commented Mar 19, 2021

A while ago, we converted API controller specs into requests specs, see #2052. But those specs still have references from their old "life" that we can clean a little bit with a small effort.

In fact, their filenames still have the _controller_ part, which makes no sense now. Eg. solidus/api/spec/requests/spree/api/addresses_controller_spec.rb

Also, they contain references to the previo

Created by David Heinemeier Hansson

Released December 13 2005

Organization
rails
Website
rubyonrails.org
Wikipedia
Wikipedia