@mcollina @targos small, but significant update, I thought force would be a better option than overwrite for when clobbering the destination folder, and have renamed it to this. Also, force now defaults to false.

CI: https://ci.nodejs.org/job/node-test-pull-request/39071/

I thought force would be a better option than overwrite for when clobbering the destination folder, and have renamed it to this. Also, force now defaults to false.

While we're rethinking options, should errorOnExist default to false or true? This is another one of those options that has its value for compat reasons.

Also, for reference; discussion thread on how fs-extra should handle the forthcoming naming conflict: jprichardson/node-fs-extra#912

@RyanZim @iansu

While we're rethinking options, should errorOnExist default to false or true? This is another one of those options that has its value for compat reasons.

I was tempted to go with false, which I believe would make copying to the same folder twice relatively safe, i.e., you don't clobber files, but it's less of a pain in the neck to recover from a partial copy (you don't have to lookup an option).

Thoughts?

FYI, waiting on a windows machine at work (there are some hiccups with provisioning). Would happily pair with someone on fixing up the failing windows test, if anyone has a system up and running.

@targos @manidlou please take another look and make sure I've addressed your comments.

CI: https://ci.nodejs.org/job/node-test-pull-request/39461/ ✅

Just want to make sure: does it behave like Unix cp when dest exists and is a directory or not?

Example, given:

• input/a.js is a file
• output/ is a directory

Execute:

• cp -r input output -> creates output/input/a.js
• cp -r input output2 -> creates output2/a.js

@targos there is not an attempt made to nest a directory under anther directory, as demonstrated in your cp -r input output -> creates output/input/a.js example.

Rather, input will be copied over output, which is the existing behavior of fs-extra copy.

Implementing this folder nesting logic would complicate the copy algorithm, and I'm not convinced it's behavior we need to carry over from cp.

@targos perhaps a compromise is to call out this difference in documentation, and pointing out that we don't support globs, and the when copying folders it's modeled after:

cp test/ test2/

When copying directories, globs are not currently supported and behavior is similar to cp dir1/ dir2/.

@bcoe @targos I'd also like to point your attention toward my comment here nodejs/tooling#98 (comment). I think it's worth mentioning it here again, our implementation of copy at fs-extra is a bit different than unix cp command, and we are aware of that but we decided to go with explicitness meaning we forced users to explicitly specify where they want their src to copy to, instead of figuring it out (internally in the code) based on the condition of src and dest.

So, I would say, if we keep it like this, it's a good idea to mention that in the docs to avoid confusion for users.

@nodejs/fs

CI: https://ci.nodejs.org/job/node-test-pull-request/39484/ ✅

CI: https://ci.nodejs.org/job/node-test-pull-request/39541/

Landed in 87d6fd7