sycl

If you pass incorrect/non-existing value into -fsycl-device-code-split option, you will get an assertion failure instead of user-friendly error message that the value is not correct:

$ touch t.cpp
$  clang++ -fsycl -fsycl-device-code-split=per-kernel t.cpp
clang++: clang/lib/Driver/ToolChains/Clang.cpp:8858: virtual void clang::driver::tools::SYCLPostLink::ConstructJob(clang::driver::C

Just an FYI whilst I was trawling through the ROCm GitHub page:

https://rocmdocs.amd.com/en/latest/Programming_Guides/Programming-Guides.html#

The problem is that the OpenCL types in https://github.com/triSYCL/triSYCL/blob/master/include/triSYCL/opencl_types.hpp are defined on the host according to the x86-64 Linux ABI which depends on the CPU & OS instead of using the description from https://www.khronos.org/registry/OpenCL/specs/2.2/html/OpenCL_C.html#built-in-scalar-data-types

Note that the system-wide cl_size_t has been removed

The cl_ types are not needed in general, however they should still be kept in the OpenCL C interop sample code.

Things like XILINX_XRT which are set by the user and others like XILINX_DEVICE_ONLY that are set by the compiler but affect the code users compile may be useful to add.