Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Fix #1345 - Improve developer experience when starting from webpack #1663

Merged
merged 2 commits into from Feb 28, 2018

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Feb 28, 2018

A few fixes:

  • Refactored some of the launch logic out to a bootstrap script, with a loading animation
  • Ping the webpack-dev-server periodically, and once we have the script, ensure that the UI is starting up

In addition, this adds an alternative mechanism for debugging:

  • npm run build-debug
  • npm run launch

This doesn't give the hot-reload functionality, so you'd have to run npm run build-debug after each change, but it's nice to have an alternative in case there are webpack issues..

@bryphe
Copy link
Member Author

bryphe commented Feb 28, 2018

Should fix #1345 and #1626

@codecov
Copy link

codecov bot commented Feb 28, 2018

Codecov Report

Merging #1663 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
+ Coverage    46.1%   46.14%   +0.04%     
==========================================
  Files         117      117              
  Lines        4449     4453       +4     
  Branches      638      638              
==========================================
+ Hits         2051     2055       +4     
  Misses       2253     2253              
  Partials      145      145
Impacted Files Coverage Δ
browser/src/Services/Snippets/SnippetManager.ts 52.08% <0%> (-1.92%) ⬇️
browser/src/Services/Snippets/SnippetSession.ts 68.8% <0%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5add3ff...2bf5418. Read the comment docs.

@bryphe bryphe merged commit b93c4db into master Feb 28, 2018
@bryphe bryphe deleted the bryphe/1345/add-loader-for-webpack branch Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant