Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[study-wrapper]: Back button overlapping #522

Merged
merged 2 commits into from Jun 22, 2021

Conversation

@ayshiff
Copy link
Contributor

@ayshiff ayshiff commented Jun 8, 2021

This PR fixes the overlapping "Back" button with the bottom navigation bar problem.

I am not really happy with my solution because it does not cover the case where the bottom bar is no longer there (when the user scrolls and when we are in desktop display).
I would love to get your feedback and know how I could improve this.

Copy link
Member

@guidezpl guidezpl left a comment

Makes the study more usable, LGTM!

@guidezpl guidezpl merged commit e6a83f8 into flutter:master Jun 22, 2021
7 checks passed
7 checks passed
@github-actions
Unit tests on ubuntu-18.04
Details
@github-actions
Unit tests on windows-2019
Details
@github-actions
Unit tests on macos-10.15
Details
@github-actions
Benchmark tests
Details
@github-actions
Golden tests
Details
@wip
WIP Ready for review
Details
@google-cla
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants