Scheduling Profiler: Add network measures #22112
Merged
+872
−136
Conversation
Better handle the case of extemely long strings (which previously draw and measures by removing one character at a time) to instead use a binary search pattern of finding the biggest string that fits.
6537f2a
to
1a6693a
1a6693a
to
7984301
Don't allow wheel events to bubble past this view even if we've scrolled to the edge. It just feels bad to have the scrolling jump unexpectedly from in a container to the outer page. The only exception is when the container fitst the contnet (no scrolling). Also don't prevent mouse move events from bubbling if dragging horizontally within a vertical scroll view or vertically within a horizontal scroll view.
7984301
to
0ed0eb9
Also slightly refactored the preprocessData data function to split separate sections out into helper functions for readability. (We can do more of this for other mark types in a follow up commit.)
0ed0eb9
to
033f932
|
exiting! this is awesome! just added a few questions |
...t-devtools-scheduling-profiler/src/view-base/HorizontalPanAndZoomView.js
Show resolved
Hide resolved
...ct-devtools-scheduling-profiler/src/content-views/NetworkMeasuresView.js
Show resolved
Hide resolved
...s/react-devtools-scheduling-profiler/src/import-worker/preprocessData.js
Show resolved
Hide resolved
packages/react-devtools-scheduling-profiler/src/content-views/utils/text.js
Show resolved
Hide resolved
f51579f
into
facebook:main
34 checks passed
34 checks passed
ci/circleci: yarn_test--r=experimental --env=development --persistent
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=stable --env=development --persistent
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=development --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-classic --env=production --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=development --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant=false
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test--r=www-modern --env=production --variant=true
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build---project=devtools -r=experimental
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build--r=experimental --env=development
Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build--r=experimental --env=production
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Several UI changes (mostly small). Commits can be reviewed individually for readability:
network-measures.mp4