Skip to content

/ CodeConverter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB => C#: Rename 'My Project' folder to Properties #665

Open
AteCoder opened this issue Oct 23, 2020 · 1 comment
Open

VB => C#: Rename 'My Project' folder to Properties #665

AteCoder opened this issue Oct 23, 2020 · 1 comment
Labels
enhancement good first issue

Comments

@AteCoder
Copy link

@AteCoder AteCoder commented Oct 23, 2020

Is your feature request related to a problem? Please describe.
Consmetics

Describe the solution you'd like
After convetion, I rename the My Project folder to Properties, which attains the characteristics of a C# project.

Describe alternatives you've considered
N/A

Additional context
N/A
@GrahamTheCoder
Copy link
Member

@GrahamTheCoder GrahamTheCoder commented Oct 24, 2020 •
edited

Seems reasonable to me!

It may be as simple as updating the target path here:

CodeConverter/CodeConverter/CSharp/VBToCSProjectContentsConverter.cs

Lines 82 to 85 in 29deb71

private string GetTargetPath(string projDirPath, WipFileConversion<SyntaxNode> r)
{
return _designerToResxRelativePath.ContainsKey(GetPathRelativeToProject(projDirPath, r.SourcePath)) ? Path.Combine(projDirPath, Path.GetFileName(r.TargetPath)) : null;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@AteCoder @GrahamTheCoder
You can’t perform that action at this time.