Effective June 1, 2021: Phabricator is no longer actively maintained.
Phabricator is a collection of web applications for software development.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.
Summary:
Fixes T13662. Phriction currently passes a map as a "context object", but this code is ancient and predates the modern meaning of a "context object". In modern code, context objects should be real objects.
Provide a real object as a context object. We do this by either loading the actual document or constructing a synthetic version of it.
Test Plan:
- Edited an existing document, observing the preview:
- Used a mention rule, saw a preview.
- Used `[[ a ]]` and `[[ ./a ]]` absolute and relative reference rules, saw accurate previews.
- Edited a new document, observing the preview:
- Used a mention rule, saw a preview.
- Used absolute/relative references, saw accurate previews.
- Grepped for other references to the removed properties (`phriction.isPreview` and `phriction.slug`), found none remaining.
Reviewers: 0
Reviewed By: 0
Maniphest Tasks: T13662
Differential Revision: https://secure.phabricator.com/D21709
8daaf5e
Effective June 1, 2021: Phabricator is no longer actively maintained.
Phabricator is a collection of web applications for software development.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.