sweetalert: ported to sweetalert2 and simplified code. #465
Conversation
|
Some screenshots would be helpful to see. You removed a lot of our customized styling. |
|
The new one looks like this: The stylesheet is coming from within sweetalert2 now, thats why its gone. |
|
Yes, but this doesn't match our theming at all. It needs to look similar to before. |
|
What do i need to adjust further to meet the theme standards you guys have in mind?
old: Do you guys need the fa icons or are the sweetalert2 css icons also okay? |
|
I opted for the fa icons for now. Screenshot: |
|
Looks good to me! Great improvement going from Sweetalert v1 to v2. |
MartB
changed the title
|
Something funky is going on with the module declaration of sweetalert2 when the explicit import is used i need to figure out why that happens. |
MartB
force-pushed the
MartB:master
branch
2 times, most recently
from
b9d7cc5
to
aabd05f
MartB
changed the title
|
The tsconfig change was nescessary to get the module definition to load with the non-auto css injecting version of the code. But feel free to correct me as this is my first time working with nodejs. |
|
Please see the tweaks I had to make to desktop app after merging here: bitwarden/desktop@663a84a We'll also need this PR in browser repo as well. |
|
Your changes look decent, I will include them where they apply. I will most likely tackle the browser by the end of this week. |
MartB
force-pushed the
MartB:master
branch
2 times, most recently
from
cec2943
to
5af981a
|
This is done from my side btw if you want any changes please tell me. |
No styling changes besides making the "primary" button-text bold (aligned with desktop app)
|
Rebased both with latest master. |
|
@MartB Testing this out now, it doesn't appear to auto-focus any of the buttons in the alert, nor can you tab into them. How do we fix that? The desktop app change seems to. |
|
@kspearrin what do you mean with auto-focus? I tested on desktop and can tab between the buttons just fine, and hitting enter submits the pin dialog just fine. Maybe try playing around with: |
|
Yes, desktop works fine, but web vault does not seem to behave the same way. |
|
Ah got ya, I misread this. |
|
@MartB Seems to be working now. Not sure what changed. |
This replaces the sweetalert library with sweetalert2.
Functionality does not change, close to no visible styling changes, verified and tested working on my instance.
This fixed at least one compile issue on NodeJS 12.X for me
This goes in-line with bitwarden/desktop#388