minify-dead-code-elimination cause regexp match infinite loop. #981

andycall · 2020-03-27T05:27:06Z

Describe the bug

To Reproduce

Minimal code to reproduce the bug

function getElementTransforms(el) {
  if (!is.dom(el)) return;
  const str = el.style.transform || '';
  const reg = /(\w+)\(([^)]*)\)/g;
  const transforms = new Map();
  let m; while (m = reg.exec(str)) transforms.set(m[1], m[2]);
  return transforms;
}

Actual Output

If there is no Error thrown,

function getElementTransforms(el) {
  if (!is.dom(el)) return;
  var str = el.style.transform || '';
  var transforms = new Map();
  var m;

  while (m = /(\w+)\(([^)]*)\)/g.exec(str)) {
    transforms.set(m[1], m[2]);
  }

  return transforms;
}

Expected Output

function getElementTransforms(el) {
  if (!is.dom(el)) return;
  var str = el.style.transform || '';
  var reg = /(\w+)\(([^)]*)\)/g;
  var transforms = new Map();
  var m;

  while (m = reg.exec(str)) {
    transforms.set(m[1], m[2]);
  }

  return transforms;
}

Configuration
Can be reproduce Using Babel's Online Try Out

babel-minify CLI

babel-plugin-minify-dead-code-elimination: 0.5.1

babel version : 7.9.0

babel-minify-config: default without config

The text was updated successfully, but these errors were encountered:

kingback · 2020-03-27T07:48:42Z

Yes，It breaks while compile querystringify
https://github.com/unshiftio/querystringify/blob/master/index.js#L48

wssgcg1213 · 2020-03-30T04:21:50Z

@kingback In our situation, we pass the compile, but make chrome 100% CPU usage and block debugging :(

kingback · 2020-03-30T06:26:02Z

@kingback In our situation, we pass the compile, but make chrome 100% CPU usage and block debugging :(

bug code

use resolutions to lock the version of @babel/types, it works for me

{
  "resolutions": {
    "@babel/types": "7.8.7"
  }
}

JLHwung · 2020-03-30T16:37:37Z

As a workaround, you may replace regexp literal by constructor calls:

--- const reg = /(\w+)\(([^)]*)\)/g;
+++ const reg = new RegExp("(\w+)\(([^)]*)\)", "g");

ChrisCindy · 2020-03-31T13:25:51Z

Should the plugin provide an option called like 'keepVariable' that doesn't eliminate variables that can be eliminated after evaluating expressions ? We have met the situation that the variables can't be replaced by its value. @JLHwung

ehoogeveen-medweb · 2020-08-17T09:28:59Z

It seems strange to me that babel-plugin-minify-dead-code-elimination is even doing anything here - after all, the code isn't dead.

Replacing named constants that are only used in one place seems like a reasonable thing to do in general, but I would expect a different plugin to be responsible for it.

mwgamble · 2020-10-15T04:07:41Z

I just ran into this with jQuery. It causes an infinite loop which makes the entire page unresponsive.

neemzy · 2021-06-02T08:14:34Z

I just ran into this with jQuery. It causes an infinite loop which makes the entire page unresponsive.

Same here!

kingback mentioned this issue Mar 27, 2020

Use babel 7.9.0 with minify-dead-code-elimination cause regexp match infinite loop. babel/babel#11343

Open

JLHwung linked a pull request that will close this issue Mar 27, 2020

Do not inline RegExp literals in loop assignment #982

Open

ChrisCindy mentioned this issue May 13, 2020

babel-plugin-minify-dead-code-elimination 插件存在问题 raxjs/rax-app#319

Closed

ota-meshi mentioned this issue Feb 25, 2021

Infinite loop with "no-useless-escape" rule mysticatea/eslint4b#8

Open

babel / minify Public

minify-dead-code-elimination cause regexp match infinite loop. #981

minify-dead-code-elimination cause regexp match infinite loop. #981

andycall commented Mar 27, 2020

kingback commented Mar 27, 2020

wssgcg1213 commented Mar 30, 2020

kingback commented Mar 30, 2020

JLHwung commented Mar 30, 2020

ChrisCindy commented Mar 31, 2020

ehoogeveen-medweb commented Aug 17, 2020

mwgamble commented Oct 15, 2020

neemzy commented Jun 2, 2021 •

edited

babel / minify Public

minify-dead-code-elimination cause regexp match infinite loop. #981

minify-dead-code-elimination cause regexp match infinite loop. #981

Comments

andycall commented Mar 27, 2020

kingback commented Mar 27, 2020

wssgcg1213 commented Mar 30, 2020

kingback commented Mar 30, 2020

JLHwung commented Mar 30, 2020

ChrisCindy commented Mar 31, 2020

ehoogeveen-medweb commented Aug 17, 2020

mwgamble commented Oct 15, 2020

neemzy commented Jun 2, 2021 • edited

neemzy commented Jun 2, 2021 •

edited