indexOf method could return -1, Potential bug

[mdrazak2001]

indexOf can cause a potential Segmentation error

the reason segmentation fault can occur is indexOf returns -1 on not finding the desired index. Hence i have added a safe if condition that is wrapped around the code which can potentially cause a segmentation error due to indexOf method.

[gaearon]

In JavaScript you can't get a segmentation error (unless the engine is buggy). You'll get undefined which will fall through to the default case which already throws the desired error. So this is not necessary.

[gaearon]

Correction: since we're not reading from array by index but doing string manipulation, what would happen is we'd get a wrong slice of the string. Regardless, the assumption here is that input is well-formed (since we're the ones who produced it in the first place). If it's not well-formed then all bets are off, and we don't strive to produce the best possible error message anyway.