Skip to content

/ serving Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the pull request workflow link on DEVELOPMENT.md #11752

Merged
merged 1 commit into from Aug 2, 2021
Merged

Update the pull request workflow link on DEVELOPMENT.md #11752

merged 1 commit into from Aug 2, 2021

Conversation

@shuheiktgw
Copy link
Contributor

@shuheiktgw shuheiktgw commented Aug 1, 2021

Proposed Changes

  • It looks like the original link is expired so I updated it with seemingly the right one

Release Note

NONE
@shuheiktgw
Update the pull request workflow link on DEVELOPMENT.md
262ac6b
@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Aug 1, 2021

Welcome @shuheiktgw! It looks like this is your first PR to knative/serving 🎉

@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Aug 1, 2021

Hi @shuheiktgw. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla google-cla bot added the cla: yes label Aug 1, 2021
markusthoemmes
markusthoemmes approved these changes Aug 2, 2021
View changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

/lgtm
/approve

Thanks!

@markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Aug 2, 2021

/ok-to-test

julz
julz approved these changes Aug 2, 2021
View changes
Copy link
Member

@julz julz left a comment

/lgtm

@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Aug 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, markusthoemmes, shuheiktgw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [julz,markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e0bbc3a into knative:main Aug 2, 2021
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julz julz

@markusthoemmes markusthoemmes

Assignees

@julz julz

@markusthoemmes markusthoemmes

Labels
approved cla: yes lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@shuheiktgw @knative-prow-robot @markusthoemmes @julz