Skip to content

Here's what's popular on GitHub today...

server

Trending repository

jina

Trending repository

jacobowitz
jacobowitz commented Aug 17, 2021

The new GrpcDataRuntime (https://github.com/jina-ai/jina/blob/master/jina/peapods/runtimes/grpc/__init__.py) does not support sharding at the moment. Thus a Flow should not specify this runtime and a sharded pod at the same time.

Right now this will not raise any error, but silently produce unexpected behavior. This is undesirable and the Flow should rather check this condition and raise an app

Emacs logo

Popular topic

Emacs is an extensible, customizable, free text editor and computing environment.
public-apis

Trending repository

matheusfelipeog
matheusfelipeog commented Aug 27, 2021

There are many inactive PRs that have already been revised and with their APIs according to our addition criteria. These PRs are just waiting for some correction that was requested by one of the maintainers, and as they are inactive PRs, they will likely not be done.

Inactive PRs must be closed and their APIs added if they still meet our criteria.

Maintainers can add the APIs of these PRs in

Game Off

Upcoming event recommended by GitHub

Nov
1

Game Off

November 01, 2021 - December 01, 2021 • Online

Game Off is an annual game jam, where participants spend the month of November creating games based on a secret theme. Participate individually, or as a team. Use whatever game engines, libraries, and languages you like.
Sider screenshot

App recommended by GitHub

Sider

Sider checks code using custom rules based on project specific knowledge and cumulative team experiences. On each pull request, Sider automatically alerts developers on previously documented issues and key information relevant to the changed code.

Trending repository

Trending repository

zfields
zfields commented Feb 12, 2021

Description

I have a hardware abstraction layer interface, as well as a driver interface. I have multiple drivers utilizing the HAL interface, while implementing the driver interface. This plugin approach causes me to have identically named tests across multiple test files.

For example:

TEST_CASE("init() returns `E_HAL_INIT`, when HardwareAbstractionLayer::init() returns an er

Trending repository

lukasm91
lukasm91 commented Aug 24, 2019

GTest exports the following targets:

  • GTest::gtest
  • GTest::gtest_main
  • GTest::gmock
  • GTest::gmock_main

This targets should also be available when adding gtest with add_subdirectory (or FetchContent), because this should behave the same way as adding GTest with find_package. So somewhere, we should add the aliases to these targets, i.e.

add_library(GTest::gtest ALIAS 

App recommended by GitHub

PullRequest

Increase velocity and reduce technical debt through code review by world-class engineers backed by automation. PullRequest provides code review with inline comments directly on your pull requests in GitHub.