Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve publishing experience #998

Merged
merged 18 commits into from Jan 25, 2019
Merged

[WIP] Improve publishing experience #998

merged 18 commits into from Jan 25, 2019

Conversation

@HenriBeck
Copy link
Member

@HenriBeck HenriBeck commented Jan 23, 2019

What would you like to add/fix?
Improving the publishing experience. It should be as easy as running on yarn command without even providing the version.

Corresponding issue (if exists): #984

HenriBeck added 4 commits Jan 22, 2019
@HenriBeck HenriBeck requested a review from kof Jan 23, 2019
HenriBeck added 11 commits Jan 23, 2019
…se scripts
…l version hook
…bal version hook

- Add script for updating the git tag
@HenriBeck HenriBeck requested review from kof and removed request for kof Jan 24, 2019
const lines = content
.split('\n')
.map(line => {
if (line.startsWith(`## ${lerna.version} (unreleased)`)) {

This comment has been minimized.

@HenriBeck

HenriBeck Jan 24, 2019
Author Member

This script is expecting the changelog to be like this for the unreleased version:

## v10.0.0-alpha.9 (unreleased)

Is this fine with you @kof or should we use instead of the version Next maybe?

This comment has been minimized.

@kof

kof Jan 25, 2019
Member

I think unreleased is better, because next is also used in dist-tag and basically means alpha for us

This comment has been minimized.

@HenriBeck

HenriBeck Jan 25, 2019
Author Member

No, unreleased is the place holder for the date. I was asking about replacing the version with Next

This comment has been minimized.

@HenriBeck

HenriBeck Jan 25, 2019
Author Member

We could have it like this:

## Next

And then the script could replace it with the version and the date.

HenriBeck added 3 commits Jan 24, 2019
@kof kof merged commit 67816f2 into master Jan 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HenriBeck HenriBeck deleted the add-publish-scripts branch Jan 29, 2019
bhupinderbola pushed a commit to bhupinderbola/jss that referenced this pull request Sep 17, 2019
* Add publish scripts

* Make prettier format package.json inside packages

* Create script for getting the changes for the current lerna version

* Add git tag command

* Don't push changes and don't tag the version by lerna

* Make versions exact

* Remove beta release script and remove explicit version of alpha release scripts

* Remove allow branch for now

* Remove version hook for individual packages and replace it with global version hook

* - Remove version hook for individual packages and replace it with global version hook
- Add script for updating the git tag

* Add empty changelogs for previous alphas

* Revert lerna.json changes

* Start on proper Changelog for alphas

* Add script for updating changelog

* Add missing changes for previous alpha versions

* Remove readme

* Remove readme

* Add readme.md again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.