Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata tables tests to make sure they don't break when reading different versions of tables #2532

Open
jackye1995 opened this issue Apr 28, 2021 · 2 comments

Comments

@jackye1995
Copy link
Contributor

@jackye1995 jackye1995 commented Apr 28, 2021

based on discussion in #2521

@taherk77
Copy link

@taherk77 taherk77 commented Apr 29, 2021

I would like to work on this issue. Can someone please guide a little and give more context?

@RussellSpitzer
Copy link
Member

@RussellSpitzer RussellSpitzer commented Apr 29, 2021

@taherk77 That would be awesome!

#2542 (comment) Here are @yyanyy 's notes on the problem. Basically we want to make sure that whether you have a v1 table or a v2 table, the metadata table code reads correctly. Our previous tests cover converting manifests but don't make sure that manifests from both versions can be accessed by the same metadata table code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants