Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for error detection in fitDataset() / standardizeDataIteratorOutput() #1238

Open
davidsoergel opened this issue Feb 13, 2019 · 4 comments

Comments

@davidsoergel
Copy link
Member

@davidsoergel davidsoergel commented Feb 13, 2019

fitDataset() expects a Dataset that produces elements of a certain shape, with matching batch sizes etc., and throws errors (from standardizeDataIteratorOutput()) when the conditions are not met. These errors should be tested.

@hpandeycodeit
Copy link

@hpandeycodeit hpandeycodeit commented Feb 19, 2019

@davidsoergel is this open to work on?

@davidsoergel
Copy link
Member Author

@davidsoergel davidsoergel commented Feb 19, 2019

@hpandeycodeit Yep, go for it!

@caisq
Copy link
Collaborator

@caisq caisq commented Feb 20, 2019

cc @kangyizhang, who is working on some integration tests for fitDataset(). @hpandeycodeit and @kangyizhang might want to coordinate.

@ManishAradwad
Copy link
Contributor

@ManishAradwad ManishAradwad commented Mar 31, 2020

I'd love working on this issue. I'll need some help:

  1. Which files should I edit / Where should I add test files?
  2. Is there some reference test file to see how it's done?
    Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.