Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body Mixin text() is supposed to return USVString #39804

Open
ronag opened this issue Aug 18, 2021 · 3 comments
Open

Body Mixin text() is supposed to return USVString #39804

ronag opened this issue Aug 18, 2021 · 3 comments
Labels
good first issue stream web streams

Comments

@ronag
Copy link
Member

@ronag ronag commented Aug 18, 2021

https://fetch.spec.whatwg.org/#body-mixin

@jasnell I think the Blob and consumer helper text() methods need to run through toUSVString which is used in the url module?
@ronag ronag changed the title Body Mixin Text is supposed to return USVString Body Mixin text() is supposed to return USVString Aug 18, 2021
@jasnell
Copy link
Member

@jasnell jasnell commented Aug 18, 2021

To be fully compliant, yes we likely need to.

@LobRockyl
Copy link

@LobRockyl LobRockyl commented Aug 23, 2021

Should I take this issue up?

@jimmywarting
Copy link

@jimmywarting jimmywarting commented Aug 27, 2021 •
edited

just notice util.toUSVString came out in 16.8, good for ppl writing polyfills... got a side question: dose TextDecoder.decode() return a USVString? cuz that is what i have been using in some .text() methods....

I also wonder what the diffrent is between USVString and a "normal" string is and doing String(val) or ${val} to convert them
Maybe stream-consumers text(iterable) should resolve with a USVString also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue stream web streams
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jasnell @jimmywarting @ronag @LobRockyl