Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Introduce Editorconfig #11857

Merged
merged 1 commit into from Feb 21, 2020
Merged

Conversation

@oliversalzburg
Copy link
Contributor

@oliversalzburg oliversalzburg commented Feb 14, 2020

Any .editorconfig was set to be ignored in cf92799.
This change introduces such a configuration file to allow contributors to use the correct code style more easily.

I'm not sure why the file was set to be ignored. IMHO it appears to be beneficial to place it in the repository to make it clear which indentation style is expected.

When I open the project in VS Code, it always attempts to indent using tabs, which is very frustrating. Obviously, I can just place my .editorconfig file from this PR into the project and resolve the issue for myself, but having the style defined right from the beginning for all developers would decrease onboarding friction.

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[X] Other... Please describe:
@Splaktar Splaktar self-assigned this Feb 21, 2020
Copy link
Member

@Splaktar Splaktar left a comment

Yes, I think that this makes a lot of sense. However, I'd like to more closely align the settings with the defaults for the Angular CLI.

.editorconfig Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
Any .editorconfig was set to be ignored in cf92799.
This change introduces such a configuration file to allow contributors to use the correct code style more easily.
Copy link
Member

@Splaktar Splaktar left a comment

LGTM

@Splaktar Splaktar assigned andrewseguin and unassigned Splaktar Feb 21, 2020
@andrewseguin andrewseguin merged commit 7ebe7a4 into angular:master Feb 21, 2020
7 checks passed
@oliversalzburg oliversalzburg deleted the feat/editorconfig branch Feb 23, 2020
@oliversalzburg oliversalzburg restored the feat/editorconfig branch Jul 13, 2020
@oliversalzburg oliversalzburg deleted the feat/editorconfig branch Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants