New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate lock-protected fields with checklocks #6566

Open

ghanan94 opened this issue Sep 13, 2021 · 2 comments

Labels

good first issue type: bug

Member

ghanan94 commented Sep 13, 2021 •

edited

Now that we have the checklocks analyzer, we should annotate values that are lock-protected with an appropriate checklocks attribute.

The text was updated successfully, but these errors were encountered:

ghanan94 added type: bug good first issue labels

BLasan commented Sep 14, 2021

@ghanan94 Hi, I'm new to the community. Does this issue need a prior knowledge on this project? Or is it ok me to take up this issue?
Thanks !!

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

d903ae1

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot mentioned this issue

Annotate checklocks on mutex protected fields #6586

Merged

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

ba9f74a

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

4cbe225

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 396758321

copybara-service bot mentioned this issue

Annotate checklocks on mutex protected fields #6591

Merged

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

f4e9674

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

5748fdd

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

3514e46

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 396758321

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

c11cd5d

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

883d903

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 396758321

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

5bd88fc

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 396758321

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

fc65b40

...to catch lock-related bugs in nogo tests.

Introduce a lock for the endpoint's frozen field as changes to frozen do
not need to be synchronized with changes made to the endpoint's other
mutex protected fields.

Updates #6566.

PiperOrigin-RevId: 396758321

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

fdd6863

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 396758321

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

94060c5

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 396758321

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

d7ffdfb

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

a8ad692

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 396946187

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

373ed15

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

c0a2b69

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

62af7c4

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

b34664b

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 396742149

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

477d7e5

...to catch lock-related bugs in nogo tests.

Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.

Updates #6566.

PiperOrigin-RevId: 397010316

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

c41574a

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot mentioned this issue

Annotate checklocks on mutex protected fields #6602

Merged

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

6128a31

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

6286db8

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

3f25657

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

596849f

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

7bfabab

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

34a2830

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

b877216

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

ce508dd

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

42f8a28

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

d82f6ad

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397129523

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

85bd3dd

...to catch lock-related bugs in nogo tests.

Checklocks also pointed out a locking violation which is fixed
in this change.

Updates #6566.

PiperOrigin-RevId: 397225322

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

3a2863d

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 397228636

copybara-service bot mentioned this issue

Annotate checklocks on mutex protected fields #6642

Open

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

f131511

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 397228636

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

97d75c6

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 400065809

copybara-service bot mentioned this issue

Annotate checklocks on mutex protected fields #6676

Merged

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

c75a3f8

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 400065809

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

d12dc32

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 400065809

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

8603cce

...to catch lock-related bugs in nogo tests.

Updates #6566.

PiperOrigin-RevId: 400265818

BLasan commented Oct 30, 2021

@ghanan94 Is this resolved?

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

7d9869f

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 416425232

copybara-service bot mentioned this issue

Annotate checklocks on mutex protected fields #6956

Merged

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

98b2b4d

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 416425232

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

f1cc06e

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 416425232

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

07f10aa

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 416425232

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

c041941

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 416425232

copybara-service bot pushed a commit that referenced this issue


          Annotate checklocks on mutex protected fields

3ca64ee

...to catch lock-related bugs in nogo tests.

This change also disables/enables packet reception before/after
save/restore with a flag that is protected by rcvMu instead of mu.

Updates #6566.

PiperOrigin-RevId: 416615336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment