Skip to content

Comments

[dashboard] Remove duplicate status header in Prebuild page#5730

Merged
roboquat merged 1 commit intomainfrom
jx/remove-duplicate-prebuild-status
Sep 17, 2021
Merged

[dashboard] Remove duplicate status header in Prebuild page#5730
roboquat merged 1 commit intomainfrom
jx/remove-duplicate-prebuild-status

Conversation

@jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Sep 17, 2021

Implements B from #5526

Description

BEFORE AFTER
Screenshot 2021-09-17 at 09 59 09 Screenshot 2021-09-17 at 09 56 36

Related Issue(s)

Fixes #5526

How to test

  1. Trigger one or more prebuilds for a project
  2. Open the prebuild page -- there should be only one status widget shown

Release Notes

NONE

@jankeromnes jankeromnes force-pushed the jx/remove-duplicate-prebuild-status branch from 596d5d7 to 7ea057a Compare September 17, 2021 07:59
@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 17, 2021

/werft run

👍 started the job as gitpod-build-jx-remove-duplicate-prebuild-status.2

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and seems to resolve #5526!

Thanks @jankeromnes! Welcome back! 🇬🇷

Deleted code is the best code. 📕

@roboquat
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 815dcd84859c9a7d34b5f7aa8c9d589e63a51edc

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis

Associated issue: #5526

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit b9789c9 into main Sep 17, 2021
@roboquat roboquat deleted the jx/remove-duplicate-prebuild-status branch September 17, 2021 13:31
@gtsiolis gtsiolis added component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. feature: prebuilds team: webapp Issue belongs to the WebApp team labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. release-note-none size/XS team: webapp Issue belongs to the WebApp team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove or adjust Prebuild status in the Prebuild page header (now duplicates the bottom status)

3 participants