Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remote state files #648

Merged
merged 1 commit into from Jun 4, 2019
Merged

feat: remote state files #648

merged 1 commit into from Jun 4, 2019

Conversation

@mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Jun 4, 2019

This change enhances helmfile to accept terraform-module-like URLs in nested state files a.k.a sub-helmfiles.

helmfiles:
- # Terraform-module-like URL for importing a remote directory and use a file in it as a nested-state file
  # The nested-state file is locally checked-out along with the remote directory containing it.
  # Therefore all the local paths in the file are resolved relative to the file
  path: git::https://github.com/cloudposse/helmfiles.git@releases/kiam.yaml?ref=0.40.0

The URL isn't equivalent to terraform module sources. The difference is that we use @ to distinguish between (1) the path to the repository and directory containing the state file and (2) the path to the state file being loaded. This distinction provides us enough fleibiity to instruct helmfile to check-out necessary and sufficient directory to make the state file works.

Under the hood, it uses hashicorp/go-getter, that is used for terraform module sources as well.

Only the git provider without authentication like git-credentials helper is tested. But theoretically any go-getter providers should work. Please feel free to test the provider of your choice and contribute documentation or instruction to use it :)

Resolves #347

@mumoshu mumoshu force-pushed the remote-state-files branch 3 times, most recently from b807e29 to acab5e6 Jun 4, 2019
This change enhances helmfile to accept terraform-module-like URLs in nested state files a.k.a sub-helmfiles.

```yaml
helmfiles:
- # Terraform-module-like URL for importing a remote directory and use a file in it as a nested-state file
  # The nested-state file is locally checked-out along with the remote directory containing it.
  # Therefore all the local paths in the file are resolved relative to the file
  path: git::https://github.com/cloudposse/helmfiles.git@releases/kiam.yaml?ref=0.40.0
```

The URL isn't equivalent to terraform module sources. The difference is that we use `@` to distinguish between (1) the path to the repository and directory containing the state file and (2) the path to the state file being loaded. This distinction provides us enough fleibiity to instruct helmfile to check-out necessary and sufficient directory to make the state file works.

Under the hood, it uses [hashicorp/go-getter](https://github.com/hashicorp/go-getter), that is used for [terraform module sources](https://www.terraform.io/docs/modules/sources.html) as well.

Only the git provider without authentication like git-credentials helper is tested. But theoretically any go-getter providers should work. Please feel free to test the provider of your choice and contribute documentation or instruction to use it :)

Resolves #347
@mumoshu mumoshu force-pushed the remote-state-files branch from acab5e6 to 6b7fc0e Jun 4, 2019
@mumoshu mumoshu merged commit 820abbc into master Jun 4, 2019
2 checks passed
@osterman
Copy link
Contributor

@osterman osterman commented Jun 4, 2019

Thank you soooooo much @mumoshu ! We will give this a shot right away.

@mumoshu mumoshu deleted the remote-state-files branch Jun 5, 2019
mumoshu added a commit that referenced this issue Jun 25, 2019
The remote helmfile feature introduced by #648 was unable to be sourced from private git repositories due to URL parsing issue in helmfile. This fixes that.

Ref #469 (comment)
mumoshu added a commit that referenced this issue Jun 25, 2019
The remote helmfile feature introduced by #648 was unable to be sourced from private git repositories due to URL parsing issue in helmfile. This fixes that.

Ref #469 (comment)
mumoshu added a commit that referenced this issue Jun 25, 2019
The remote helmfile feature introduced by #648 was unable to be sourced from private git repositories due to URL parsing issue in helmfile. This fixes that.

Ref #469 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants