Remove emojis from async.md #3893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree |
AlexandreMarcq
approved these changes
Sep 21, 2021
|
I reviewed the French translation, everything is clear. |
|
Reviewed the Spanish translation, everything is clear there as well. |
onionj
approved these changes
Jul 3, 2022
TMSantos
reviewed
Jul 4, 2022
| @@ -63,13 +63,13 @@ Vamos ver aquela frase por partes na seção abaixo: | |||
|
|
|||
| ## Código assíncrono | |||
|
|
|||
| Código assíncrono apenas significa que a linguagem 💬 tem um jeito de dizer para o computador / programa 🤖 que em certo ponto, ele 🤖 terá que esperar por *algo* para finalizar em outro lugar. Vamos dizer que esse *algo* seja chamado "arquivo lento" 📝. | |||
| Código assíncrono apenas significa que a linguagem 💬 tem um jeito de dizer para o computador / programa que em certo ponto, ele terá que esperar por *algo* para finalizar em outro lugar. Vamos dizer que esse *algo* seja chamado "arquivo lento" 📝. | |||
|
|
|||
There was a problem hiding this comment.
some emojis are still left in PT version
|
Closing because the docs have been updated: #3273 (comment) |
tiangolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR removes all emojis from the documentation page
async.mdto help with readability.A while back, I opened an issue regarding the amount of emojis in👍 vs 2👎 )!
async.md(#3273).Since then, the overwhelming majority has expressed their support in removing emojis from the page (25+
With these changes, I can read the page much more easily (more details in the issue above).
This PR should not be considered complete yet. The non-english versions have to be read by native speakers to make sure I didn't accidentally remove emojis which replaced verbs or nouns in a sentence.
In addition, this PR is a 100% removal of emojis - I'm sure they can be added back but in a less distracting manner (maybe only once and not after every instance of a word). I appreciate any comments regarding this.