Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github personal access token #672

Merged
merged 8 commits into from Sep 6, 2021
Merged

Conversation

@daiyam
Copy link
Collaborator

@daiyam daiyam commented Mar 19, 2021

This PR is replacing the cumbersome auth relay server (#401) with github personal access token.

How to create a PAT: https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token

@pmahend1
Copy link

@pmahend1 pmahend1 commented Apr 10, 2021

I was looking at the issues for this and came across this. Is it possible to have app level Auth provider without PAT, may be that will help other extensions use the same provider seemlessly without users having to manually enter PAT?

Loading

@daiyam
Copy link
Collaborator Author

@daiyam daiyam commented Aug 1, 2021

Loading

@zyansheep
Copy link

@zyansheep zyansheep commented Aug 14, 2021

What is the holdup on this getting merged?

Loading

@daiyam
Copy link
Collaborator Author

@daiyam daiyam commented Aug 14, 2021

@stripedpajamas What do you think about this PR?

Loading

@stripedpajamas
Copy link
Member

@stripedpajamas stripedpajamas commented Sep 1, 2021

It feels to me like it will be a pain to maintain this patch as upstream continues development. It's fine to merge it in, just foreseeing it drift like the other patches and this one is more complex imo.

Loading

@daiyam
Copy link
Collaborator Author

@daiyam daiyam commented Sep 1, 2021

@stripedpajamas This patch isn't so complex. I just remove some parts of the code, nothing more. So it's easy.
I will add a section in the doc about that change, then I will merge it.

Loading

prepare_vscode.sh Outdated Show resolved Hide resolved
Loading
@GitMensch
Copy link
Collaborator

@GitMensch GitMensch commented Sep 6, 2021

Looks good to me, I'd also merge after CI is finished. It should definitely be integrated into tonight's 1.60!

Loading

@daiyam
Copy link
Collaborator Author

@daiyam daiyam commented Sep 6, 2021

@GitMensch Yep. That's why I've made it.

Loading

@daiyam
Copy link
Collaborator Author

@daiyam daiyam commented Sep 6, 2021

@GitMensch Can you check the doc if it's good enough? Thx

Loading

@GitMensch
Copy link
Collaborator

@GitMensch GitMensch commented Sep 6, 2021

I already did,and wanted to explicit write "thanks for the doc update", somehow that got lost from my typing...
Yes, docs are fine. Thanks again.

Loading

@daiyam daiyam merged commit 0d43389 into VSCodium:master Sep 6, 2021
7 checks passed
Loading
@daiyam daiyam deleted the use-github-pat branch Sep 6, 2021
@rugk
Copy link

@rugk rugk commented Sep 7, 2021

FYI, did I mention that GitHub doing diff's on .diff files is absolutely crazy?

Just when you need something to laugh look un unified view at one or few commits in this PR: 😅

image

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants