Add coverage as a separate babel loader if loaders already exist #63
Conversation
| @@ -115,21 +133,7 @@ export function addWebpackConfig(karmaConfig, pkg, options) { | |||
| // devtool: 'module-source-map', | |||
| mode: webpackConfig.mode || 'development', | |||
| module: { | |||
| // @TODO check webpack version and use loaders VS rules as the key here appropriately: | |||
andrewiggins
Aug 14, 2020
Author
Collaborator
I think this TODO is handled by line 180 below so I removed it
I think this TODO is handled by line 180 below so I removed it
|
I wonder if we could inject this into any existing Or maybe something like a |
|
I took a stab at adding to existing loaders in the latest commit. Does that look right? I also updated the webpack-custom test to use a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
With the new E2E test suite, I noticed that coverage is not properly reported when the user provides a custom webpack.config.js. This PR fixes that by detecting if webpack loaders exist and if so, adding a new babel-loader with just the coverage plugin enabled.
Our tests also now enforce that coverage is correctly reported for all tests.