[Java][WebClient] add ResponseEntity return for webclient #9327
+788
−89
Conversation
cb806f0
to
8fae191
lincetto
approved these changes
May 6, 2021
|
Is it possible to give a boost to this PR? Thanks :) |
8fae191
to
b245495
|
Hi, I rebase my branch with latest master to be up to date but CircleCI failed. |
|
Any news about this PR ? |
wing328
reviewed
Jun 17, 2021
modules/openapi-generator/src/main/resources/Java/libraries/webclient/api.mustache
Show resolved
Hide resolved
b245495
to
44aa73d
simplification to avoir duplicated code
|
Here a new proposal with merged function to avoid duplicated code |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.xFor now we done it by overriding templates but as I have a bit of time and I found that there is already an issue about that, I propose this PR
fix: #5599
For review (java) :
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)
The text was updated successfully, but these errors were encountered: