Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: skip pipes and other special files when determining which files to extract #6857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JS: skip pipes and other special files when determining which files to extract #6857

wants to merge 1 commit into from
+1 −1

Conversation

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Oct 12, 2021

I don't think we can add a test for this.
@erik-krogh
skip pipes and other special files when determining which files to ex…
7d4266a 
…tract
@erik-krogh erik-krogh requested a review from as a code owner Oct 12, 2021
@github-actions github-actions bot added the JS label Oct 12, 2021
@hmakholm
Copy link
Contributor

@hmakholm hmakholm commented Oct 12, 2021

It ought to be possible to add a test to the internal integration tests -- for example, execute an mkfifo src/a-pipe in integration-tests/all-platforms/multi_extract/codeql_create_database if the platform is not Windows.

@erik-krogh
Copy link
Contributor Author

@erik-krogh erik-krogh commented Oct 12, 2021

It ought to be possible to add a test to the internal integration tests -- for example, execute an mkfifo src/a-pipe in integration-tests/all-platforms/multi_extract/codeql_create_database if the platform is not Windows.

I've added such a test in the internal integration tests.
I'm thinking to merge that test after this PR is merged, that way I don't have to bump a submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-javascript codeql-javascript

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@erik-krogh @hmakholm