Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxi): explicitly set listen options only when they are provided #1033

Closed
wants to merge 1 commit into from
Closed

fix(nuxi): explicitly set listen options only when they are provided #1033

wants to merge 1 commit into from

Conversation

@danielroe
Copy link
Member

@danielroe danielroe commented Oct 14, 2021

🔗 Linked issue

resolves #1032

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This avoids setting undefined properties by checking first. Alternatively, we could filter object.entries.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
@danielroe
fix(nuxi): explicitly set listen options only when they are provided
0dcd3c2
@danielroe danielroe requested a review from pi0 Oct 14, 2021
@danielroe danielroe self-assigned this Oct 14, 2021
@netlify
Copy link

@netlify netlify bot commented Oct 14, 2021 •
edited

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: 0dcd3c2

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/616833032fc8e60007b5d717

@pi0
Copy link
Member

@pi0 pi0 commented Oct 14, 2021

Upstream issue fixed: unjs/listhen@f866a61

pi0 added a commit that referenced this issue Oct 14, 2021
@pi0
fix(cli): update listhen (resolves #1032, #1033)
83862bb
@pi0 pi0 closed this Oct 14, 2021
@pi0 pi0 deleted the fix/cli-listhen branch Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0

Assignees

@danielroe danielroe

Labels
bug cli
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

nuxi is now listening on undefined:3000
2 participants
@danielroe @pi0