This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nitro): enable externals for azure and firebase presets
#1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
βοΈ Deploy Preview for nuxt3-docs canceled. π¨ Explore the source changes: 5d23c77 π Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6168b2e81153530008099ee4 |
pi0
changed the title
azure and firebase presets
pi0
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#12039
β Type of change
π Description
When
node-fetchis inlined, it breaks the polyfilling offetch(just try withnitro.externals: false). This will need to be resolved (or identified).However, we should be supporting externals for these presets in any case, and that solves the immediate issue.
π Checklist