Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input group validation with custom-file input #33239

Merged
merged 6 commits into from Oct 21, 2021

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Mar 2, 2021

First try to fix #32867 — introduced with #31962.

Simple shot for now, not sure I totally understood what's been done — mostly the nth-last-child(n + 3) part, I'm certainly missing a test case to check this.


Previews:

@ffoodd ffoodd marked this pull request as ready for review Mar 2, 2021
@ffoodd ffoodd requested a review from as a code owner Mar 2, 2021
@XhmikosR XhmikosR added this to Inbox in v4.6.1 via automation Mar 16, 2021
@XhmikosR XhmikosR requested a review from mdo May 1, 2021
@ffoodd
Copy link
Member Author

@ffoodd ffoodd commented Sep 1, 2021

Friendly ping @twbs/css-review :)

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 8, 2021

@mdo ping

mdo
mdo approved these changes Oct 9, 2021
@XhmikosR XhmikosR merged commit e482fbb into v4-dev Oct 21, 2021
27 checks passed
@XhmikosR XhmikosR deleted the v4-dev-fod-validated-input-group-with-custom-file branch Oct 21, 2021
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.6.1 Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.6.1
Shipped
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants