chore: deprecate object syntax for proxy#3224
Closed
rishabh3112 wants to merge 4 commits intowebpack:masterfrom
Closed
chore: deprecate object syntax for proxy#3224rishabh3112 wants to merge 4 commits intowebpack:masterfrom
rishabh3112 wants to merge 4 commits intowebpack:masterfrom
Conversation
rishabh3112
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3224 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 37 37
Lines 1248 1249 +1
Branches 352 352
=======================================
+ Hits 1188 1189 +1
Misses 54 54
Partials 6 6
Continue to review full report at Codecov.
|
noharashinchan
approved these changes
May 2, 2021
6 tasks
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Sorry for delay and fixed in master and in 5.0.0 version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Will do if required.
Motivation / Use-Case
#2454
#2454 (comment)
Breaking Changes
Additional Info